search

sbidy / pywizlight

A python connector for WiZ devices
MIT License
463 stars 79 forks source link

Fix missing effects on dimmable white bulbs and add test coverage #129

Closed bdraco closed 2 years ago

bdraco commented 2 years ago

So far nothing has broken with the older devices I have been receiving from ebay. Effects are missing from dimmable white bulbs

I'm adding the output to the tests though so if we do change something or add support for a new thing in the future we will know if we broke old firmware compat.

codecov-commenter commented 2 years ago

Codecov Report

Merging #129 (beb1861) into master (b06b386) will increase coverage by 0.37%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   87.56%   87.93%   +0.37%     
==========================================
  Files          12       12              
  Lines         796      796              
==========================================
+ Hits          697      700       +3     
+ Misses         99       96       -3
Impacted Files Coverage Δ
pywizlight/push_manager.py 90.90% <0.00%> (+3.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b06b386...beb1861. Read the comment docs.

bdraco commented 2 years ago

This once could use a new release when you have a moment