search

sbidy / pywizlight

A python connector for WiZ devices
MIT License
463 stars 79 forks source link

Ensure late arriving messages from previous requests are ignored #136

Closed bdraco closed 2 years ago

bdraco commented 2 years ago

Fixes #135

codecov-commenter commented 2 years ago

Codecov Report

Merging #136 (1732c97) into master (3199eb5) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   89.39%   89.41%   +0.01%     
==========================================
  Files          12       12              
  Lines         858      869      +11     
==========================================
+ Hits          767      777      +10     
- Misses         91       92       +1
Impacted Files Coverage Δ
pywizlight/bulb.py 90.49% <100.00%> (+0.01%) :arrow_up:
pywizlight/push_manager.py 98.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3199eb5...1732c97. Read the comment docs.

bdraco commented 2 years ago

This one should probably get another release since its pretty easy to replicate when the firmware is updating on a newly setup bulb which leads to the config flow discovery being aborted if it happens to not reply on the first request when its out of box firmware doesn't support getModelConfig

bdraco commented 2 years ago

Looks like you already pushed .12 🚀