General code quality fixes

[akx]

This PR applies a bunch of general code quality & typing fixes. In that, it may fix some future or corner-case bugs.

👉 I would strongly advise this PR not be squash-merged in case trouble arises down the line; it would make it a lot easier to bisect (not to mention git annotates look better).

In particular:

• f-strings are used everywhere (since this is 3.7+)
• dataclasses are used everywhere
• fixes typing so mypy --strict now passes fully for the codebase
• all of PyCharm's "Problems" complaints are dealt with
  • methods that needn't be methods are now free functions
• use of modern py.test features
  • all tests pass, of course

Some future improvements might include:

• turning PilotBuilder into a function that simply accepts a bunch of optional kwargs and returns a payload
• turning PilotParser into a function that accepts a response and returns a dataclass
• changing naming of external interfaces to be PEP8 compliant (PascalCase and snake_case); I didn't do this yet since it would be a semver-major change.
• adding py.typed since this package should now be soundly typed

Of course please let me know if you want this e.g. split into multiple PRs, or if there's any concerns :)

[sbidy]

@akx awesome changes!! Thank you! It's a good point to refactor the PilotBuilder and PiloteParser into a clean function, but this will break eventually some integrations. But I will be more readable and usable with functions.

[sbidy]

@all-contributors please add @akx code

[allcontributors[bot]]

@sbidy

I've put up a pull request to add @akx! :tada:

[akx]

@akx awesome changes!! Thank you! It's a good point to refactor the PilotBuilder and PiloteParser into a clean function, but this will break eventually some integrations. But I will be more readable and usable with functions.

@sbidy Thank you!

Sure - those breaking changes could be done in the next semver-major update (0.5.x or 0.6.x maybe?).

Can you approve GH workflows for this PR (first-time contributors need approval) so I can see if there's anything that needs changes lint-wise?

[akx]

@sbidy I rebased this and fixed the issues that occurred in CI, but I had to edit the workflow file to do so, so you'll need to re-approve :)

[akx]

@sbidy Fixed the last CI fix. Once more with feeling, as they say! You can see the checks having succeeded over at https://github.com/akx/pywizlight/pull/1 ...

[sbidy]

Yes, hopefully I can get my hands on the PR to merge this in the next days. Thank you for the CI fix...