I recently installed your integration in Home Assistant noticed some presumbily outdated information and typos that I fixed, so I'd be happy if you accept my pull request.
The outdated parts are
Removed section about unsupported effects
I noticed that I can set effects from the Lovelace Dashboard, so I removed the line stating that this feature will not be supported because HA doesn't support it with it's API. I suppose HA updated their API and you added the feature and just forgot to update the Readme as well
Added video guide on installation through HACS
Following the discussion in this repo I noticed that getting this integration merged in homeassistant-core is quite demanding, but it's available in the Home Assistant Community Store. So this should be the official installation method, at least until it gets accepted into core, right? For now I just added a link to a youtube video that describes installation via HACS, but if this is indeed the preferred installation method I'd be happy to write a detailed text instruction for installation via HACS to include in the Readme.
Please let me know if you have any concerns with this PR.
At last I can only thank you for your great work, the cheap bulbs in combination with your library offer some great opportunities for a cloudless smart home solution.
Hi @sbidy,
I recently installed your integration in Home Assistant noticed some presumbily outdated information and typos that I fixed, so I'd be happy if you accept my pull request.
The outdated parts are
Removed section about unsupported effects
I noticed that I can set effects from the Lovelace Dashboard, so I removed the line stating that this feature will not be supported because HA doesn't support it with it's API. I suppose HA updated their API and you added the feature and just forgot to update the Readme as well
Added video guide on installation through HACS
Following the discussion in this repo I noticed that getting this integration merged in homeassistant-core is quite demanding, but it's available in the Home Assistant Community Store. So this should be the official installation method, at least until it gets accepted into core, right? For now I just added a link to a youtube video that describes installation via HACS, but if this is indeed the preferred installation method I'd be happy to write a detailed text instruction for installation via HACS to include in the Readme.
Please let me know if you have any concerns with this PR.
At last I can only thank you for your great work, the cheap bulbs in combination with your library offer some great opportunities for a cloudless smart home solution.