sbidy / wiz_light

A WiZ Light integration for Home Assistant
MIT License
341 stars 68 forks source link

G25 filament bulb supported features #18

Closed danVnest closed 4 years ago

danVnest commented 4 years ago

WiZ G25 filament bulbs (ESP56_SHTW3_01) support colour temperature and effects as well as brightness change.

Perhaps fix in light.py by changing

# Firlament bulbs support only dimmer
if self._bulbType == 'ESP56_SHTW3_01':
    _LOGGER.info("Found ESP56_SHTW3_01 bulb")
    return SUPPORT_BRIGHTNESS

to

# Filament bulbs support brightness and color temperature
if self._bulbType == 'ESP56_SHTW3_01':
    _LOGGER.info("Found ESP56_SHTW3_01 bulb")
    return SUPPORT_BRIGHTNESS | SUPPORT_COLOR_TEMP | SUPPORT_EFFECT

The above does work, however, these lights don't support all effects, only those in the screenshot below (these are those that don't change colour, only colour temperature). This would either require a list of effects for each different bulb type; or filtering the scenes by supported features. IMG_4936

sbidy commented 4 years ago

Now supported with the correct features. Please test if all effects are available. I think I forgot the Cozy ... ๐Ÿ˜„ Note: I don't added the "warm white" and "cold white" effect. In my opinion this is no a real effect and can be controlled better in the HA automation.

Please test the new version an give me a feedback! ๐Ÿ˜ƒ Thank you for the contribution!!

danVnest commented 4 years ago

Works perfectly, thank you! The missing effects donโ€™t matter to me.