search

sbidy / wiz_light

A WiZ Light integration for Home Assistant
MIT License
341 stars 68 forks source link

Expose Infos like IP, DNS name etc. of the Wiz Light #215

Closed hwinkel closed 2 years ago

hwinkel commented 2 years ago

Can the Device Info or Diagnostic text Sensor be extened with the Info about the IP Adress and may other Values of the Light (WiFi, RSSI etc) ?

sbidy commented 2 years ago

Ah, that's a good point, but I have to look up what possible for from the HASS side. The lib behind can provide such info.

hwinkel commented 2 years ago

New HA support config url for device. And new entity categories for diagnostic sensors which can be hidden in the first place

quielb commented 2 years ago

I agree that the info you are asking for would be helpful to see. Problem is that data is considered static data. The Diagnostic/Configuration sensors are meant for dynamic data, things that have a state that changes over time. Probably the only thing that would fit that category would be RSSI. I've been through this before with the core HA team and they would most likely reject a submission like that. They would say that info belongs on the Device info page of the integration for each device. There are many fields that live in the device registry that cover the attributes you are asking for.

I would like to throw in firmware version as another attribute to add to the device info page.

bdraco commented 2 years ago

This can be closed as the firmware and hardware version has been added to the core version, and the rest won't be added for the following reasons:

The RSSI is a very chatty sensor so we generally don't add these.

The ip address is already stored in the config entry. Currently there is no way to display this in the UI though. There is an arch issue open on that https://github.com/home-assistant/architecture/discussions/717