sbillak / mobile-bookmark-bubble

Automatically exported from code.google.com/p/mobile-bookmark-bubble
Apache License 2.0
0 stars 0 forks source link

Position of Bubble on iPad needs to be changed #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open a site with the bubble on the iPad
2. Bubble positioned at the bottom of the screen pointing to nothing.

What is the expected output? What do you see instead?

Bubble should be positioned along the top and underneath the bookmark button

What version of the product are you using? On what operating system?

iPad 1st Gen (iOS 3.2)

Please provide any additional information below.

Diff with alternate positioning for iPad attached. Working example here: 
http://digitalize.ca/mobile-bookmark/example.html

Original issue reported on code.google.com by batmoo on 15 Oct 2010 at 9:27

Attachments:

GoogleCodeExporter commented 9 years ago
I modified the patch slightly to match the Google JavaScript Style Guide 
(http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml) and to 
delay computing the hidden Y position until after the bubble element has been 
added to the DOM (otherwise querying the offsetHeight will always return 0).

The change has now been committed as changeset 3d3f5ed84d.

Thanks, batmoo!

Original comment by ntho...@google.com on 18 Oct 2010 at 1:52