search

sbinet / go-python

naive go bindings to the CPython2 C-API
Other
1.53k stars 138 forks source link

Added PyCode_NewEmpty binding. #19

Closed eliothedeman closed 9 years ago

sbinet commented 9 years ago

LGTM, modulo the little typo :)

eliothedeman commented 9 years ago

Yup, forgot to free... my bad.

sbinet commented 9 years ago

thanks. could you address the little typo in the docstring ?

eliothedeman commented 9 years ago

Yeah sorry about the trouble. I hope to keep helping, just wanted to get my feet wet first.

sbinet commented 9 years ago

no worries, and thanks again. keep them coming.

sbinet commented 9 years ago

ok, I cleaned up a bit your code and sent #20

next time, could you create a branch and send the pull request from that branch instead of from your master ? (I was starting to see your developments wrt byte-slices and integers...)

eliothedeman commented 9 years ago

ahh yes, will do. Sorry