search

sbird / fake_spectra

A code for generating fake spectra from a cosmological simulation
MIT License
12 stars 13 forks source link

Progress counter & small 'fix' to T0 and gamma fit #16

Closed Chris-Pedersen closed 5 years ago

Chris-Pedersen commented 5 years ago

This PR contains the progress counter we discussed a while back, and a small fix to the T0 and gamma fit script to still give sensible results if the temp and or density arrays contain 0s (which lead to -inf in the log10 arrrays).

sbird commented 5 years ago

Thanks - I'll merge it if you quickly address the comments (you can use git rebase -i to edit the commits in place).

One quick question though: under what circumstances were you finding zero temperature or density? Was it zero density or zero temperature? And was it related to the "only-on-dirac" problem with MP-Gadget?

Chris-Pedersen commented 5 years ago

I've had instances of zeros in both arrays, in sims on both DiRAC and Hypatia that don't appear to have any other problems. Should we look more into this?

sbird commented 5 years ago

hmm, yes please. Double check whether the mass of these particles is also zero. There may be an under-run somewhere. Are you leaving MinGasTemp at the default value of 5K?

sbird commented 5 years ago

Zero mass particles are not a fatal problem but it's worth looking into :) If you can email me the full parameter files and the slurm output, and let me know at what redshift the zero-mass points emerged, I can try and take a look next week.

Chris-Pedersen commented 5 years ago

Sure I'll take a look and let you know via email.

sbird commented 5 years ago

Cheers