adding get_observer_tau() to spectra

sbird / fake_spectra

A code for generating fake spectra from a cosmological simulation

MIT License

12 stars 13 forks source link

adding get_observer_tau() to spectra #25

Closed qezlou closed 4 years ago

qezlou commented 4 years ago

How do you think about adding this method from vw_Sepctra to Spectra ? Then we can simply save it while we are generating spectra (I could not find any other convenient way to save these)

rr = randspectra(...)
rr.get_tau()
rr.get_observer_tau()
rr.savefile()

I have checked it, it is compatible with being here.

sbird commented 4 years ago

Yes, why not? I think I split them after the last time I used it so I never found out how irritating it was. Will merge.

qezlou commented 4 years ago

So, do you prefer I blend vw_spectra functions with spectra gradually ? Also there are functions from vw_plotspectra that can be transferred to fake_spectra.plot_spectra . If you are ok with that, please let me know then I will send pull requests .