search

sbird / fake_spectra

A code for generating fake spectra from a cosmological simulation
MIT License
12 stars 13 forks source link

namespace contamination #4

Closed rainwoodman closed 7 years ago

rainwoodman commented 7 years ago

By glancing at setup.py, it appears that fake_spectra installs a horde of toplevel python packages to the system.

While this gets the work done, introducing too many symbols to the global python package namespace is probably not a good idea.

Changing this behavior will probably break a lot of downstream analysis scripts; but the fix could be as easy as changing a few imports.

sbird commented 7 years ago

This will not break downstram analysis scripts too much (as I don't use setup.py locally) but I don't really know how distutils works. Do you have a suggested fix?

rainwoodman commented 7 years ago

Let me add a demo PR.

sbird commented 7 years ago

Thanks

rainwoodman commented 7 years ago

Closed by #5