search

sbird / fake_spectra

A code for generating fake spectra from a cosmological simulation
MIT License
12 stars 13 forks source link

Allow RateNetworkSpectra to specify gamma_factor and temp_factor #44

Closed andreufont closed 4 years ago

andreufont commented 4 years ago

RateNetworkGas works with user-provided values of gamma_factor and temp_factor, to do temperature rescalings, but RateNeworkSpectra does not have these as options in the constructor.

I'll submit a pull request to add these as options in the constructor of the spectra class.

andreufont commented 4 years ago

Actually, it looks like it also needs to pass several other options to RateNetwork, at least treecool_file, but possibly others like redshift or hubble (it defaults to h=0.71).

I wonder whether RateNetworkSpectra has been used before, maybe I'm the first one trying to use it? I remember I was the one that asked for it a long time ago, sorry I never went back to this until now.