sbird / fake_spectra

A code for generating fake spectra from a cosmological simulation
MIT License
12 stars 13 forks source link

added option to specify value of H(z) to use #59

Closed andreufont closed 3 years ago

andreufont commented 3 years ago

This small PR addresses issue #57 , by adding an option to specify the value of H(z) to be used when extracting the flux.

For consistency, this value is now also stored in the spectra files, and it is read when reading pre-computed spectra.

These are the possible working modes: A) when extracting skewers from snapshot A.1) if use_external_Hz is not provided it will compute it in flat LCDM A.2) if use_external_Hz is provided it will use this value B) when reading old skewers from file (that did not have Hz stored, and assumed flat LCDM) B.1) if use_external_Hz is not provided it will compute it in flat LCDM B.2) if use_external_Hz is provided it will check that it agrees with the one computed in flat LCDM C) when reading new skewers from file (that have Hz stored) C.1) if use_external_Hz is not provided it will use the value of Hz read from file C.2) if use_external_Hz is provided it will check that it agrees with the one read from file

I checked that indeed this is what happens by running some tests on my laptop.

sbird commented 3 years ago

Looks good, thanks!