sbis04 / sign_in_flutter

"Login Demo" app which shows how to use google sign in Android and iOS using Flutter.
https://www.souvikbiswas.com/flutter-firebase-auth
MIT License
203 stars 83 forks source link

For Test run its Fails #6

Closed sabarinathancs closed 4 years ago

sabarinathancs commented 4 years ago

WhatsApp Image 2019-12-26 at 1 39 19 AM

daniele777 commented 4 years ago

How to solve?

vpxoxo commented 4 years ago

got the same error here, seems like there is something wrong with the google profile image URL?

vpxoxo commented 4 years ago

Hi I found that in sign_in.dart, these should be used.

Future<FirebaseUser> signInWithGoogle() async {

return user;

also i commented out the circular avatar part for the image in the login page because it didn't work

hope this helps!!

daniele777 commented 4 years ago

You solve this issue ?

vpxoxo commented 4 years ago

Yes it works for me now using the above method. 👍🏻

daniele777 commented 4 years ago

How ?? Need to add only return ??

Il gio 27 feb 2020, 07:23 vpxoxo notifications@github.com ha scritto:

Yes it works for me now using the above method. 👍🏻

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sbis04/sign_in_flutter/issues/6?email_source=notifications&email_token=AB7USHGDHI3253QAGQDAE3TRE5L55A5CNFSM4J7GLAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDDONI#issuecomment-591804213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7USHF66PLEU6KF2CNY6HDRE5L55ANCNFSM4J7GLAEQ .

vpxoxo commented 4 years ago

I mean do the following two changes:

change this https://github.com/sbis04/sign_in_flutter/blob/5ad9067111942c1dff253e056456ce2f1d91ca4b/lib/sign_in.dart#L31 to this Future<FirebaseUser> signInWithGoogle() async {

and change this https://github.com/sbis04/sign_in_flutter/blob/5ad9067111942c1dff253e056456ce2f1d91ca4b/lib/sign_in.dart#L64 to this return user;

daniele777 commented 4 years ago

Thank you !!!!

vpxoxo commented 4 years ago

no prob!!

sbis04 commented 4 years ago

Thanks @vpxoxo for solving this issue. 🎉