search

sbis04 / video_trimmer

Flutter video trimmer package
https://pub.dev/packages/video_trimmer
MIT License
440 stars 271 forks source link

App size increased heavily #32

Closed avvari-da closed 2 years ago

avvari-da commented 4 years ago

This is a great plugin, but my app bundle size increased by about 40 mb after adding this package.

Is there a way to reduce this? Or is it something I can't avoid?

flutter doctor ``` Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.5 19F101, locale en-IN) [✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2) [✓] Xcode - develop for iOS and macOS (Xcode 11.5) [✓] Android Studio (version 4.0) [!] IntelliJ IDEA Community Edition (version 2020.1) ✗ Flutter plugin not installed; this adds Flutter specific functionality. ✗ Dart plugin not installed; this adds Dart specific functionality. [✓] VS Code (version 1.36.1) [✓] Connected device (1 available) ! Doctor found issues in 1 category. ```
wilfredonoyola commented 4 years ago

@dheeraj2dj I think this was added for the package "flutter_ffmpeg" because the video_trimmer use flutter_ffmpeg as manager the video editor.

But, I think is not posible reduce the size for your app while use the package flutter_ffmpeg.

Another long-term solution could be to create the trim video functionality with native code for Android and IOS. But I am sure it requires hard work to implement the basic functions as the library currently does "flutter_ffmpeg". But in general, the "flutter_ffmpeg" library is a problem in that sense, because we need apps that are small in size, mainly in Google Play, In this way avoid that users are not encouraged to download our application.

Let me know your thoughts @sbis04

leochiu-work commented 4 years ago

For the flutter_ffmpeg packages listed here https://github.com/sbis04/video_trimmer#ffmpeg-release

Will the plugin still working if we use min-lts? And will the app size smaller as well? Currently I am using full-lts.

avvari-da commented 4 years ago

@leochiu-work I was using min-gpl-lts, still the huge size. Will try min-lts

masfour7 commented 4 years ago

@dheeraj2dj Have you tried using the min-lts?

avvari-da commented 4 years ago

@masfour7 yea, but no advantage. Reduced just 1-2 mb

jonasN5 commented 4 years ago

There are already existing native libraries doing the heavy lifting. I could write an Android plugin within 2 weeks, but don't have any iOS knowledge. If someone can write the iOS counter part, we could setup a native lib to avoid using ffmpeg. There is no other solution to the size problem.

pooja96km commented 3 years ago

Has anyone found the solution?

jonasN5 commented 3 years ago

Has anyone found the solution?

Still hoping someone can write the iOS part ^^

pooja96km commented 3 years ago

Has anyone found the solution?

Still hoping someone can write the iOS part ^^ Have you written for android?

jonasN5 commented 3 years ago

Not yet, but can do it quickly. But useless for a flutter app without iOS, so I'm waiting for someone that can do that before I start.

pooja96km commented 3 years ago

Not yet, but can do it quickly. But useless for a flutter app without iOS, so I'm waiting for someone that can do that before I start.

Ok

ArjanAswal commented 3 years ago

Has anyone found the solution?

Still hoping someone can write the iOS part ^^

@themadmrj I recommend that you go ahead with an android-only implementation. People will certainly start to contribute to your repo as your plugin starts picking up the pace, and someone will come up with an implementation for iOS.

jonasN5 commented 3 years ago

Has anyone found the solution?

Still hoping someone can write the iOS part ^^

@themadmrj I recommend that you go ahead with an android-only implementation. People will certainly start to contribute to your repo as your plugin starts picking up the pace, and someone will come up with an implementation for iOS.

Not so sure about that. Without external reference like an article on Medium, a repo lacks visibility and may not get contribution. For instance, I wrote a chat UI library because dashchat is inactive, which is a lot more complete, and yet it doesn't really pick up the pace! If someone would just commit with me, that would certainly give me the push. The problem is, even if I write an android only lib, I can't use it myself unless it cover both platforms xD

aliaktas-tr commented 2 years ago

Did anyone find any solition?

sbis04 commented 2 years ago

Closing this issue because there have been a few changes to the ffmpeg_kit_flutter. Please open a new issue if you want to discuss this further.