search

sbitxdev / sbitx

1 stars 0 forks source link

Bug: FT8's first qso not logging properly #6

Open afarhan opened 5 months ago

afarhan commented 5 months ago

Gyula and two others have reported this. It is a bummer to lose a good contact just because this doesn't work. This is probably the last of the bugs in the logger that will make it useful on FT8.

afarhan commented 5 months ago

fixed

n1ai commented 5 months ago

Please show which code commit fixed the problem instead of just saying 'fixed'.

MolKa51 commented 5 months ago

Dave, you can find the modified program in the main branch. I tested it and now it works correctly. Gyula, HA3HZ

afarhan commented 5 months ago

Just pull the latest.

On Fri, Feb 16, 2024, 1:45 AM Gyula Molnar @.***> wrote:

Dave, you can find the modified program in the main branch. I tested it and now it works correctly.

— Reply to this email directly, view it on GitHub https://github.com/sbitxdev/sbitx/issues/6#issuecomment-1947238468, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFYXOCZSN235C2HIEBQZ4DYTZUFHAVCNFSM6AAAAABC5IOO7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXGIZTQNBWHA . You are receiving this because you modified the open/close state.Message ID: @.***>

n1ai commented 5 months ago

"Just pull the latest" is the wrong approach to community software development.

You need to be able to show the commit that fixed the bug and/or the exact lines that were changed to fix the bug.

This helps others learn more about how the code works and perhaps how to make future improvements.

afarhan commented 5 months ago

You are right. I should push branches of each issue on sbitxdev and have it reviewed.

On Fri, Feb 16, 2024, 8:02 PM n1ai @.***> wrote:

"Just pull the latest" is the wrong approach to community software development.

You need to be able to show the commit that fixed the bug and/or the exact lines that were changed to fix the bug.

This helps others learn more about how the code works and perhaps how to make future improvements.

— Reply to this email directly, view it on GitHub https://github.com/sbitxdev/sbitx/issues/6#issuecomment-1948487641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFYXODEBXEUCHE42BG2OQDYT5UWBAVCNFSM6AAAAABC5IOO7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBYGQ4DONRUGE . You are receiving this because you modified the open/close state.Message ID: @.***>