sblaisot / certbot-dns-01-authenticators

GNU General Public License v3.0
18 stars 13 forks source link

fix auth on both domain.tld and *.domain.tld for ovh #5

Open stephanepoinsart opened 6 years ago

stephanepoinsart commented 6 years ago

Hello.

When adding both domain.tld and *.domain.tld to a certificate, the script is run 2 times, the TXT has the same key but a different value. Some people reported it in comments here : https://blog.blaisot.org/letsencrypt-wildcard-part2.html

This is an fix attempt by comparing the TXT value to CERTBOT_VALIDATION and not just the existence of the record.

As my cert was already renewed, i did not test it on the final version of the script in real life conditions (I just know DNS edits looks ok).

Could possibly still fail : the refresh command "result = client.post('/domain/zone/' + certbot_domain + '/refresh')" may be ignored if ovh decide it's not good to call it very fast, so maybe the wait loop might timeout, even if everything is in place to validate the domain.