search

sblakemore / cleanflight

Clean-code version of the baseflight flight controller firmware
http://cleanflight.com
GNU General Public License v3.0
0 stars 0 forks source link

Renaming command vtx to vtxaux #4

Open jflyper opened 8 years ago

jflyper commented 8 years ago

@sblakemore This one is minor. It may be a matter of taste, but the vtx command resembles to me something more broad and powerful(?) than aux switch definitions; like the serial command specifying device configuration. I'm more comfortable with "vtxaux", but since the change causes compatibility problem for existing users of the singularity fc, I would leave the decision up to you.

sblakemore commented 8 years ago

I'm open to the suggestion to change, 'vtx' is possibly a little broad.

The question that comes to me is if there is further functionality needed that would require a command, would it be better to have multiple commands or make this one more sophisticated.

Would it be better to have vtxaux and vtxpwr commands, or have the command work as 'vtx aux x x x' and 'vtx pwr x x x'?

jflyper commented 8 years ago

Regarding the further functionality, I'm already working on a new vtx_mode 3, in which frequencies are selected by channel stick from user defined band. The band is defined with vtxcustom command (e.g.: vtxcustom 5740 5760 5785 ... and so on).

Command syntax... I'm not sure. Subcommands requires additional comparisons (which otherwise be done in top level command dispatcher) in cliVtx(), so it is not space efficient at least, while adding bunch of vtxXXX commands may irritate some people ;->

sblakemore commented 8 years ago

All the custom commands I can imagine at this time still seem to be quite close in functionality. I think my preference is sub commands personally. :)