search

sblakey / obsidian-quip

Obsidian plugin to publish notes to Quip.com
MIT License
24 stars 4 forks source link

Import fails if document contains a mailto link #20

Open colegleason opened 1 year ago

colegleason commented 1 year ago

When importing a quip document with a mailto link, the import fails on this line: https://github.com/sblakey/obsidian-quip/blob/fb38812c7b0182227c13d8bf36b33acbbe80ab65/src/Importer.ts#L33

The trace is:

plugin:quip:1316 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'split')
    at Importer.process_A (plugin:quip:1316:55)
    at Importer.importHTML (plugin:quip:1345:18)
process_A @ plugin:quip:1316
importHTML @ plugin:quip:1345

Essentially the if statement is not correctly guarding against mailto links because the hostname of the URI is an empty string.