search

sblantipodi / glow_worm_luciferin

Bias Lighting and Ambient Light firmware, designed for Firefly Luciferin.
GNU General Public License v3.0
158 stars 19 forks source link

[Bug]: Setup Web Interface requires internet connection #52

Closed jkowalk closed 1 year ago

jkowalk commented 1 year ago

Firefly Luciferin version

-

Glow Worm Luciferin version

5.10.6

Firmware type

FULL

What is the stream method?

WiFi Stream

Fiefly Luciferin config file

No response

Relevant log output

No response

How to reproduce

I just noticed, that with the newest firmware version the setup page, that you can access over the hotspot if not configuration was found, relies on files on the public internet. Unless your device has an internet connection and is connected to the hotspot of the esp at the same time, the interface is not usable because the files cannot be downloaded.

In version 5.9.7 this is not an issue.

Here are some pictures how the web interface on 5.10.6 looks like if only connected to the device hotspot: Web Interface Unreachable files
image image

Thanks a lot for your work!

sblantipodi commented 1 year ago

Hi @jkowalk thanks for pointing this out...

This is not really a bug but a design choice to reduce the firmware footprint.

is there some real world scenarios where devices are not connected to the internet this days?

jkowalk commented 1 year ago

OK, I see your point. It depends on the way the operating system handles the different networks. On Windows with Ethernet connected to the Internet and Wi-Fi connected to the Esp, all resources were loaded. But on my smartphone (Android 12) it only used the Wi-Fi and ignored the cellular connection. So the page was unusable there.

I guess the setup page doesn't need to be anything fancy, just a simple form will do the job. Maybe it's possible to include the JavaScript so that it is still possible to submit the settings.

sblantipodi commented 1 year ago

@jkowalk great point. adding the keep label and fixing it in the future... :)