sblantipodi
commented
8 months ago Hi @krisrok, I'm sorry for the late reply but holidays added a bit of delay to my answers :)
I have reviewed your PR and it seems that it lacks a lot of features that are required to add support for a new led strip:
- There is no addition to the CI process (GitHub Actions). Firmware is not stored somewhere for public use, no release.
- GPIOs are hardcoded, this is obviously not good for a multi user project.
- There is no way to select WS2801 option from the web interface.
- There is no way to select WS2801 option from the Firefly Luciferin PC client.
I always appreciate pull requests and thank you very much for taking time in creating it, said that this PR can't be merged in this state.
There is even another thing. Luciferin is a new project and I would like it to remain as light and fast as possible, for this reason I would prefer not to add support for "old LED strips or old microcontrollers".
It is obviously in everyone's interest to add support for new technologies, new microcontrollers and new LED strips but adding support for products that will be dismissed soon doesn't add much.
krisrok
To avoid messing with PC host application there is no additional color mode, it replaces the RGB/UART mode. Therefore, SPI support has to be activated via RGB_SPI directive. See env:glowwormluciferinlight_spi_esp8266 in platformio.ini.
Uses GPIO2 as DATA and also GPIO4 as CLK.