search

sblask-webextensions / webextension-skip-redirect

Some web pages use intermediary pages before redirecting to a final page. This add-on tries to extract the final url from the intermediary url and goes there straight away if successful.
https://addons.mozilla.org/firefox/addon/skip-redirect/
MIT License
489 stars 45 forks source link

no skip urls list - add firefox portal detection url #355

Closed wesinator closed 1 year ago

wesinator commented 1 year ago

This PR adds the firefox captive portal detection redirect URL to the no-skip list.

Problem: currently, wifi redirect pages that use the Firefox captive portal URL in a parameter are redirected by the extension, breaking the captive portal login in many cases.

sblask commented 1 year ago

I am not sure I understand the problem. It sounds like the captive portal detection is a Firefox feature that does stuff in the background. Why would a wifi portal have the URL in their URL?

wesinator commented 1 year ago

I am not sure I understand the problem. It sounds like the captive portal detection is a Firefox feature that does stuff in the background. Why would a wifi portal have the URL in their URL?

I had this case with Boingo hotspot: https://wifi.boingohotspot.net/stl.hotspot/?dst=http://detectportal.firefox.com/canonical.html&link_login_only=https://via.boingohotspot.net/login&link_login=https://via.boingohotspot.net/login?dst=http://detectportal.firefox.com/canonical.html&link_logout=https://via.boingohotspot.net/logout&link_status=https://via.boingohotspot.net/status&nas_identifier=ccg_stl-via1&hostname=via.boingohotspot.net&identity=via-2.0&ip=<>&mac=<>&GSID=<>&vlan_id=3&__c9auth=1

I guess maybe it doesn't make sense to add exclusions for this

I'm maintaining a list of exclusions at https://gist.github.com/wesinator/a1d7aeed25a17d01ccec91e1188de6fd

sblask commented 1 year ago

I am going to close this. People with the same problem should be able to find this issue and your list can help them. Thanks!