sblask-webextensions / webextension-skip-redirect

Some web pages use intermediary pages before redirecting to a final page. This add-on tries to extract the final url from the intermediary url and goes there straight away if successful.
https://addons.mozilla.org/firefox/addon/skip-redirect/
MIT License
489 stars 45 forks source link

Wrong URL picked for redirection #91

Closed mooms06 closed 6 years ago

mooms06 commented 6 years ago

New Issue Checklist (tick off like this: [x])

What is your browser?

What is your operating system?

Description (please include examples/screenshots where applicable)

Skip redirect is not working correctly in the URL posted in this post: https://forum.hardware.fr/forum2.php?config=hfr.inc&cat=4&post=338104&numreponse=3307541

The URL in question: http://hardware.digidip.net/visit?url=https%3A%2F%2Fblogs.technet.microsoft.com%2Ffilecab%2F2017%2F06%2F01%2Fsmb1-product-clearinghouse%2F&ppref=https%3A%2F%2Fforum.hardware.fr%2Fforum1.php%3Fconfig%3Dhfr.inc%26cat%3D4%26page%3D1%26subcat%3D0%26sondage%3D0%26owntopic%3D3%26trash%3D0%26trash_post%3D0%26moderation%3D0%26new%3D0%26nojs%3D0%26subcatgroup%3D0&currurl=https%3A%2F%2Fforum.hardware.fr%2Fforum2.php%3Fconfig%3Dhfr.inc%26cat%3D4%26subcat%3D570%26post%3D348715%26page%3D1%26p%3D1%26sondage%3D0%26owntopic%3D3%26trash%3D0%26trash_post%3D0%26print%3D0%26numreponse%3D0%26quote_only%3D0%26new%3D0%26nojs%3D0

It should redirect to https://blogs.technet.microsoft.com/filecab/2017/06/01/smb1-product-clearinghouse/ (behavior when skip redirect is disabled).

Bu instead it redirect to https://forum.hardware.fr/forum2.php?config=hfr.inc&cat=4&subcat=570&post=348715&page=1&p=1&sondage=0&owntopic=3&trash=0&trash_post=0&print=0&numreponse=0&quote_only=0&new=0&nojs=0

sblask commented 6 years ago

This has been discussed before, there is no way of knowing which one is the right URL. You'll have to disable Skip Redirect for hardware.digidip.net