sblunt / orbitize

Orbit-fitting for directly imaged objects
https://orbitize.info
Other
74 stars 43 forks source link

Update save results tutorial for OFTI #181

Closed rferrerc closed 4 years ago

rferrerc commented 4 years ago

Fixes #173

Changed "saving and loading results" section in OFTI tutorial, instead of saving using the h5py module, saving directly with orbitize.Results.save_results().

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1197


Files with Coverage Reduction New Missed Lines %
orbitize/results.py 2 80.63%
orbitize/sampler.py 2 94.43%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 1167: -0.02%
Covered Lines: 1030
Relevant Lines: 1177

💛 - Coveralls
semaphoreP commented 4 years ago

A couple of things:

1) Might be good to include how to load orbitize results with the Results() class. Or point to the demo in the MCMC tutorial (http://orbitize.info/en/latest/tutorials/MCMC_tutorial.html#Saving-and-Loading-Results).

2) Did you mean to include the code from PR #180 in here too?

sblunt commented 4 years ago

Also this one. Looks ready to go when you've addressed Jason's suggestions.