sblunt / orbitize

Orbit-fitting for directly imaged objects
https://orbitize.info
Other
79 stars 44 forks source link

warning for tau_ref_epoch change in kepler.calc_orbit #187

Closed semaphoreP closed 4 years ago

semaphoreP commented 4 years ago

Addresses issue #182. After changing the hard coded tau_ref_epoch to be in line with default value in system.py, I added a new optional flag to kepler.calc_orbit that automatically throws a warning each time it's called, unless the flag is set to False. I've set the flag to False for every internal orbitize call to calc_orbit so users just using standard orbitize! API will not get this warning. However, users calling it from their own scripts will get this warning, and will need to explicitly turn it off themselves.

How does that sound for a solution to transition out of the default tau_ref_epoch being 0 in calc_orbit?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1230


Totals Coverage Status
Change from base Build 1226: 0.1%
Covered Lines: 1044
Relevant Lines: 1189

💛 - Coveralls
sblunt commented 4 years ago

Addresses Issue #182