sblunt / orbitize

Orbit-fitting for directly imaged objects
https://orbitize.info
Other
79 stars 44 forks source link

Make plotting robust against super long periods #241

Closed semaphoreP closed 3 years ago

semaphoreP commented 3 years ago

If we have periods > 10^9 days, the epochs array of results.plot_orbit is unable to convert from MJD to decimal error due to an issue with astropy.time. This is so far in the future that we should catch this error and limit the colorbar to be between some reasonable dates.

Reproduction: Run the RV MCMC Tutorial Notebook and the plot_orbit will throw an error because we have some really long periods.

sblunt commented 3 years ago

Jason notes that this only in the colorbar epoch conversion. See his suggestion above.

sblunt commented 3 years ago

Addressed in PR #276