search

sblunt / orbitize

Orbit-fitting for directly imaged objects
https://orbitize.info
Other
74 stars 43 forks source link

load_results bug with hipparcos iad fits #315

Closed rbowru closed 2 years ago

rbowru commented 2 years ago

When I attempt to use load_results to open a .hdf5 file that was made from a fit that included hipparcos/gaia astrometry, I get an error that says "ValueError: could not convert string to float." I've included the full output in a screenshot: Screen Shot 2022-03-31 at 2 26 01 PM

Thanks!

sblunt commented 2 years ago

Hey Rachel, thanks for raising this issue! I couldn't reproduce this error-- check out tests/test_hipparcos.py unit test I just added (test_save_load())

Do you have the most updated version of orbitize? If so, can you share the code you're using to save the results object?

sblunt commented 2 years ago

Oh, one thought-- are you defining the Gaia dr number as a string?

rbowru commented 2 years ago

Oh, good catch! I was not defining the edr3 number as a string! When I have a good break in the simulations that I'm trying to run, I'll make sure this solved the problem. Thank you!

sblunt commented 2 years ago

@rbowru did this fix work?

sblunt commented 2 years ago

Closing, feel free to reopen if needed.