search

sblunt / orbitize

Orbit-fitting for directly imaged objects
https://orbitize.info
Other
74 stars 43 forks source link

Updated deprecated numpy functions #331

Closed tomasstolker closed 1 year ago

tomasstolker commented 1 year ago

This is a minor PR that fixes the issue related to several deprecated numpy functions (in version 1.24) for certain data types (see issues #330 and #329).

I have updated the use of np.float, np.int, and np.str. This fix should also work with numpy versions older than 1.24.

Not related, but I also added a warning in plot_orbits related to the rv_time_series parameter, just for convenience.

Let me know in case you have any feedback 😊

sblunt commented 1 year ago

Thanks so much for the fix, @tomasstolker, and sorry it took me a while to get around to looking at this. I was able to reproduce the error referenced in #329 and #330, and this fixed it. Thanks for the warning addition as well.