sblunt / orbitize

Orbit-fitting for directly imaged objects
https://orbitize.info
Other
74 stars 43 forks source link

Raised Error when using RV data #351

Closed juague135 closed 6 months ago

juague135 commented 9 months ago

Orbitize raises an exception when attempting to use a dataset with RV data. "Exception: If including RV data in orbit fit, set fit_secondary_mass=True"

semaphoreP commented 9 months ago

Note that this is the case of only planetary RV

sblunt commented 6 months ago

Hey Juan, finally getting around to addressing this bug! I think in the meantime, I must have fixed this somewhere along the line, because I can't reproduce it any more. I was fiddling with the companion rv implementation a lot around this time, so I'm sure it's buried somewhere in all the commit messages. I added a unit test to check this scenario and make sure it stays fixed in the future (in #363). Please reopen if you run into this issue again!