fix for Result File From Resumed MCMC Fails to Save #370

sblunt / orbitize

Orbit-fitting for directly imaged objects

https://orbitize.info

Other

74 stars 43 forks source link

fix for Result File From Resumed MCMC Fails to Save #370 #374

Closed sblunt closed 3 weeks ago

sblunt commented 1 month ago

Hey @HenryDennen and @wbalmer, thanks for raising an issue about this! I could reproduce your issue, and the patch in this PR fixes it for me. Could you confirm that this works for you too, then I can pull it into main? Thanks!!

sblunt commented 1 month ago

I also extended an existing unit test to cover this situation, since the bug was occurring only after:

orbit run with Hipparcos IAD
orbit fit saved
orbit fit loaded into new results file
that new orbit fit is saved

semaphoreP commented 1 month ago

The fix is just to not delete the tmp file? Is that correct?

sblunt commented 1 month ago

yup!

wbalmer commented 1 month ago

I just confirmed that the fix works for Henry's gist example and some of my own code. Thanks Sarah!