sbmako / NServiceBus.MongoDB

MongoDB persistence for NServiceBus
MIT License
13 stars 9 forks source link

Update to NServiceBus v7? #29

Open andreasohlund opened 6 years ago

andreasohlund commented 6 years ago

With v7 just right around the corner are there any plans to update the persister to support it? (there should not be any dramatic changes on the persistence seam)

Let let me know if you need any help

sbmako commented 6 years ago

Yes. I will be updating it. I am also looking into supporting .net core.

andreasohlund commented 6 years ago

Awesome, let me know if you need any help, pr-reviews etc On Wed, 14 Mar 2018 at 18:37, Carlos Sandoval notifications@github.com wrote:

Yes. I will be updating it. I am also looking into supporting .net core.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sbmako/NServiceBus.MongoDB/issues/29#issuecomment-373110437, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHoZHaOGetcjxYF3yO430jQ7dUKIUHDks5teVVHgaJpZM4SqkyB .

kpko commented 6 years ago

Hi, can you already tell us what the current state of the implementation looks like? It would be awesome to be able to use MongoDB persistence in NServiceBus 7.

sbmako commented 6 years ago

There is a pre-release version available on nuget.org. We have been using it for a short while now and have not experienced any issues. There is also a working version of it using .net core which is a work in progress on a branch.

Please let me know if you find anything

willwolfram18 commented 6 years ago

@sbmako Are there any details on when this will move out of pre-release and into a production version of the package?

sbmako commented 6 years ago

As i mentioned, we have not had any issues yet but i am looking to get some feedback from other users. Maybe by first of this month?

Thoughts?

willwolfram18 commented 6 years ago

Is the plan to have the project target NET Standard 2.0 instead of .NET 4.6.1 when it's released?

sbmako commented 6 years ago

Correct. There is already dotnet core branch that does exactly that. There is also a pre-release nuget package on nuget.org.

willwolfram18 commented 6 years ago

I do see the dotnet core branch, however it appears that NServiceBus.MongoDB pre-release package was restored using .NET Framework 4.6.1 which results in a warning in projects targeting NET Core App that use the package. image

Package 'NServiceBus.MongoDB 7.0.2-nsb7.1' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'. This package may not be fully compatible with your project.

Pulling down the solution, it appears that the package is targeting NET Standard 2.0, and it doesn't appear any dependencies are targeting .NET Framework when the project is built. Perhaps it's an issue with how AppVeyor does the build step?

sbmako commented 6 years ago

Thanks, will take care of that.

sbmako commented 6 years ago

There is another pre-release package: https://www.nuget.org/packages/NServiceBus.MongoDB/7.0.2-dotnet-core.1

willwolfram18 commented 6 years ago

Apparently I never noticed that one 😢 Sorry about that! Thanks for the help!