search

sbmlteam / jsbml

JSBML is a community-driven project to create a free, open-source, pure Java™ library for reading, writing, and manipulating SBML files (the Systems Biology Markup Language) and data streams. It is an alternative to the mixed Java/native code-based interface provided in libSBML.
https://sbml.org/software/jsbml/
GNU Lesser General Public License v2.1
37 stars 24 forks source link

processUnknownAttribute() needing to be called explicitly in SpatialParser #168

Closed bhavyejain closed 5 years ago

bhavyejain commented 5 years ago

Handling of unknown attributes is already done in SBMLReader https://github.com/sbmlteam/jsbml/blob/8ea32d6aef94624f0b9110e8a41a58303b2a8c99/core/src/org/sbml/jsbml/xml/stax/SBMLReader.java#L1196

But to get the UnknownPackageAttributeValidationFunction working for spatial, it had to be added explicitly in SpatialParser. This should not have been required.

https://github.com/sbmlteam/jsbml/blob/500be9dac9020b93a3848e67464bf06ada2bfbed/extensions/spatial/src/org/sbml/jsbml/xml/parsers/SpatialParser.java#L252-L254

The problem can be tested by running tests for the rule spatial-20401 from SpatialSpeciesPluginConstraints.