sbmlteam / libCombine

a C++ library for working with the COMBINE Archive format
BSD 2-Clause "Simplified" License
8 stars 5 forks source link

location '.' is missing from the entries #17

Closed matthiaskoenig closed 7 years ago

matthiaskoenig commented 7 years ago

When iterating over the entries the location '.' is not part of the entries.

See for instance the test python examples

********************************************************************************
Archive created: testdata/out.omex
********************************************************************************
Print archive: testdata/out.omex
********************************************************************************
  metadata for '.':
     Created : 2017-09-15T13:47:33Z
     Modified : 2017-09-15T13:47:33Z
     # Creators: 1
       Frank Bergmann
Num Entries: 1
 0: location: ./models/model.xml format: http://identifiers.org/combine.specifications/sbml
  no metadata for './models/model.xml'

This should be:

Num Entries: 2
0: location: .
  metadata for '.':
     Created : 2017-09-15T13:47:33Z
     Modified : 2017-09-15T13:47:33Z
     # Creators: 1
       Frank Bergmann
 1: location: ./models/model.xml format: http://identifiers.org/combine.specifications/sbml
  no metadata for './models/model.xml'
fbergmann commented 7 years ago

We could argue about that one :) ... I again feel that since '.' is the archive itself, it ought to not count as an entry of the archive ...

fbergmann commented 7 years ago

coming from the philosophy, that what counts is the contents of the CA rather than that something has been wrapped in a CA

matthiaskoenig commented 7 years ago

Okay, makes sense. Was not sure if this was on purpose. But no problem to work with the current behavior. Thanks