Closed matthiaskoenig closed 7 years ago
Bummer ... the specification should have said must
rather than should
in this case. It makes no sense to me otherwise. But I will try and alter it for the full release.
thanks for letting me know.
Yes, should be must. In addition I think the metadata is broken in general
See example attached: archive_example.zip
Example only displays the single creator for . (there are multiple creators), does not show the modified and misses all metadata for the other entries.
Probably the hashmap for the metadata given locations is not populated correctly:
metadata for '.':
Created : 2000-01-01T00:00:00Z
Creators: 1
Vasundra Toure
Num Entries: 20
0
entry: <0> <libcombine.CaContent; proxy of <Swig Object of type 'CaContent *' at 0x7fa29bf664e0> >
0: location: ./manifest.xml format: http://identifiers.org/combine.specifications/omex-manifest
no metadata for './manifest.xml'
1
entry: <1> <libcombine.CaContent; proxy of <Swig Object of type 'CaContent *' at 0x7fa29bf66570> >
1: location: ./README.md format: http://purl.org/NET/mediatypes/text/x-markdown
no metadata for './README.md'
2
entry: <2> <libcombine.CaContent; proxy of <Swig Object of type 'CaContent *' at 0x7fa29bf664e0> >
2: location: ./model/BIOMD0000000144.xml format: http://identifiers.org/combine.specifications/sbml.level-2.version-1
no metadata for './model/BIOMD0000000144.xml'
3
entry: <3> <libcombine.CaContent; proxy of <Swig Object of type 'CaContent *' at 0x7fa29bf66570> >
3: location: ./model/calzone_2007.ai format: http://purl.org/NET/mediatypes/application/illustrator
no metadata for './model/calzone_2007.ai'
4
...
I will have a look ... when i'm using it i usually have one metadata file per file where i want to attach meta information. But it should have been able to read the rest. I will let you know what i find.
After sleeping over it, I think the specification should be interpreted as 'must'. And libcombine should also handle it as must without workarounds. The only thing libcombine should do is to check if there are metadata.rdf entries which do not have a corresponding entry in the omex file and give a warning (error) of the form
WARNING: Metadata rdf:about='/README.md' does not have any entry
in the OMEX manifest. rdf:about and OMEX manifest location must be identical.
Than users will know that there is a problem mapping and can fix the archives. Fix for CombineShowCase archive is done https://github.com/SemsProject/CombineArchiveShowCase/pull/6
The original issue is solved. RDF and metadata locations have to be identical.
Hi all, currently the metadata from the CombineArchiveShowcase cannot be read, because the leading
.
is missing in the rdf:about.The problem is that the locations in the omex are given as:
whereas the rdf:abouts are
The metadata should be resolved with and without the leading
.
, especially because the Omex specification only states that these should be identical (no must).In my opinion a problem with the combineShowCaseArchive and reported it there.
But libcombine should be so flexible to handle the leading
.
,./
and no leading character cases.M