Various small fixes - Githubissues

sbmlteam / libsbml

LibSBML is a native library for reading, writing and manipulating files and data streams containing the Systems Biology Markup Language (SBML). It offers language bindings for C, C++, C#, Java, JavaScript, MATLAB, Perl, PHP, Python, R and Ruby.

https://sbml.org/software/libsbml

Other

39 stars 28 forks source link

Various small fixes #326

Closed skeating closed 1 year ago

skeating commented 1 year ago

Description

Various small fixes from issues

Motivation and Context

Fixes #149 Fixes #324 Fixes #37 Fixes #325 Fixes #328 Fixes #134

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Change in documentation

Checklist:

[ ] I have updated all documentation necessary.
[ ] I have checked spelling in (new) comments.

Testing

[X] Testing is done automatically and codecov shows test coverage
[ ] This cannot be tested automatically

fbergmann commented 1 year ago

I still think the best change would be to not have the constructors throw exceptions at all (that does not help anyone IMO). But if we cannot change that, I think it would be better not to introduce the variables (e) that we don't use. What do you think?