search

sbmlteam / sbml-test-suite

The SBML Test Suite is a conformance testing system. It allows developers and users to test the degree and correctness of the SBML support provided in a software package.
https://sbml.org/software/sbml-test-suite/
Other
23 stars 12 forks source link

Test Runner crashes when changing Level and Version (and test results exists) #68

Closed matthiaskoenig closed 4 years ago

matthiaskoenig commented 4 years ago

This could be related to #67. If I ran some tests and then change the Level and Version in the Drop-Down Menu the GUI crashes. This is reproducible. Workaround is to go in the test output directory and delete all CSV, then one can change the Level and Version.

On ubuntu 18.04, using the downloaded deb package from the latest release.

fbergmann commented 4 years ago

that does seem odd ... could you please give me (just some csv files and your wrapper configuration) so i can reproduce it? It would also be good to know what version of the testrunner you are running (that would be in the about menu)

For me this seems to be working fine:

https://p194.p3.n0.cdn.getcloudapp.com/items/8LujvvXZ/Screen%20Recording%202020-05-29%20at%2003.18.47.17%20PM.gif?v=4b74a175a121fbf3d1cbbb6ebc2c5b0c

fbergmann commented 4 years ago

I've looked at the other issue, and the other issue was something completely different (but that one is solved). I've checked out the runner on 18.04 and it works there for me too. To reproduce: 

cd src/test-runner/testsuite-ui
TESTRUNNER_IGNORE_ARCHIVE=true TESTRUNNER_IGNORE_HELP=true ant jar 
TESTRUNNER_IGNORE_ARCHIVE=true TESTRUNNER_IGNORE_HELP=true ant start-linux-64

I do get gazillions of assertions ... but those are not thrown by us, but by glib ... so i'm not worried about those.

matthiaskoenig commented 4 years ago

I deleted the error messages from before, they were related to a different issue not related to the test runner. The errors I get are the following:

org.eclipse.swt.SWTException: Widget is disposed
    at org.eclipse.swt.SWT.error(SWT.java:4537)
    at org.eclipse.swt.SWT.error(SWT.java:4452)
    at org.eclipse.swt.SWT.error(SWT.java:4423)
    at org.eclipse.swt.widgets.Widget.error(Widget.java:502)
    at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:439)
    at org.eclipse.swt.custom.StyledText.setText(StyledText.java:10105)
    at org.sbml.testsuite.ui.ProgressSection.setStatus(ProgressSection.java:153)
    at org.sbml.testsuite.ui.MainWindow.updateProgressSection(MainWindow.java:2065)
    at org.sbml.testsuite.ui.MainWindow.updateProgressSection(MainWindow.java:2082)
    at org.sbml.testsuite.ui.MainWindow.access$1100(MainWindow.java:109)
    at org.sbml.testsuite.ui.MainWindow$57.run(MainWindow.java:2056)
    at org.eclipse.swt.widgets.Display.timerProc(Display.java:5484)
    at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
    at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2133)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4413)
    at org.eclipse.swt.widgets.Display.release(Display.java:4470)
    at org.eclipse.swt.graphics.Device.dispose(Device.java:235)
    at org.sbml.testsuite.ui.MainWindow.open(MainWindow.java:2863)
    at org.sbml.testsuite.ui.Program.main(Program.java:58)

Using version 3.3.0 (the Ubuntu deb which is available as download).

Attached the CSV I have in my output folder sbscl-test-suite.zip

Here the screenshot of my test wrapper Screenshot from 2020-05-30 09-44-06

matthiaskoenig commented 4 years ago

Attached video of the issue 2020-05-30 09-48-18.zip

matthiaskoenig commented 4 years ago

I just rebuild with ant from the latest develop commit (6306a88a1f401756e52a4b608c5987f793fd5547 https://github.com/sbmlteam/sbml-test-suite/commit/6306a88a1f401756e52a4b608c5987f793fd5547)

Using 

cd src/test-runner/testsuite-ui
TESTRUNNER_IGNORE_ARCHIVE=true TESTRUNNER_IGNORE_HELP=true ant jar 
TESTRUNNER_IGNORE_ARCHIVE=true TESTRUNNER_IGNORE_HELP=true ant start-linux-64

Now when changing level and version the GUI is not dying, but just freezing on the Refreshing results list ;) so some improvement. Screenshot from 2020-05-30 10-05-42

fbergmann commented 4 years ago

and indeed there were some files in that results set, that were not parsable:

image

should work now ... from master

mhucka commented 4 years ago

I will merge this change to branch develop.

matthiaskoenig commented 4 years ago

Perfect. Works like a charm. Thanks so much.