sbmlteam / sbml-test-suite

The SBML Test Suite is a conformance testing system. It allows developers and users to test the degree and correctness of the SBML support provided in a software package.
https://sbml.org/software/sbml-test-suite/
Other
23 stars 12 forks source link

Interpretation of case 48 #85

Open paulflang opened 2 years ago

paulflang commented 2 years ago

I do not know why it is possible to get a simulation result for test case 48. We have

Now I would think that this model cannot be solved, cause the concentration, not the amount of S1 needs to be plugged into the kineticLaw. However, we cannot know the concentration of S1, as we don't know the size of compartment. What am I getting wrong?

(Please let me know if there is a better channel to discuss this)

luciansmith commented 2 years ago

This is a fine place to discuss the issue.

There were many rules in place in SBML L1 and L2 about 0D compartments, but those rules were dropped for SBML L3. However, as you have discovered, this means that tests like this are no longer accurate.

I believe the way to fix this is to set hasOnlySubstanceUnits to 'true' for the L3 models. We should also make sure this happens when L2 models are translated to L3 in general.

luciansmith commented 2 years ago

https://github.com/sbmlteam/sbml-test-suite/pull/86

(Although the other option is to just drop the L3 versions of these tests.)

paulflang commented 2 years ago

Thanks for clarifying, Lucian!