sboesen / remotely-sync

fork of remotely-save with security upgrades
Apache License 2.0
180 stars 8 forks source link

[Bug]: Pause in syncing causes sync status to update to last synced #102

Closed kadisonm closed 6 months ago

kadisonm commented 6 months ago

What happened?

If an item takes longer to sync then the status bar will update to the last synced, then get set back to the status bar.

Need to refactor sync status to use the same lastSynced as Sync on Remote (they're both saving essentially the same thing). I should be able to take a look and fix this. :)

What OS are you using?

Windows

What remote cloud services are you using?

Dropbox

Version of the plugin

No response

Version of Obsidian

No response

Using password or not

Ensure no sensitive information

sboesen commented 6 months ago

If an item takes longer to sync then the status bar will update to the last synced

Awesome! I am not sure what this means exactly but sounds like you have a plan to fix it - appreciate all the effort you've put in here!!

kadisonm commented 6 months ago

Sorry I'll elaborate aha. Believe this only really happens on a lower concurrency, but I found the 'start syncing' and 'finish syncing' stopped for a second or two (which I presume is it taking longer to upload). During this the status bar turned back to 'last synced x minutes ago'. Once the item finished syncing it went back to showing the sync status.

I suspect that something is updating the status bar during this but I need to have a look.

sboesen commented 6 months ago

Ah, gotcha, I have seen that in the past* I think. Not really sure why that behavior happens.

kadisonm commented 6 months ago

I believe I fixed this by refactoring how the status bar is updated. I'll make a PR.