Status bar fixes + refactor

kadisonm commented 6 months ago

Fixes #102 as I refactored how the status bar is updated. Made it so the status bar is updated whenever the plugin's syncStatus variable is updated. This cleaned up the syncRun code a lot as it doesn't have to worry about updating the status bar anymore (just the sync status).
Fixes #104. All the operations are on the same queue now. Made it so that deletion ops don't update the status bar. In the case the user doesn't upload folders, or upload/downloads, the status bar would only switch to preparing (no sync info gets given). So to fix this I added a 'Syncing' in the lang. This is noticeable when the user syncs on no changes.
Stops Sync on Remote running if there is no metadata.
Made it so Sync on Remote only runs on start up if there has been a remote sync. (Made last sync on settings so it persists)
Fixed the ribbon bar's aria label not resetting after a sync. Would be stuck as 'Remotely Sync: manual'.

Please let me know your opinion on this PR and if you wan't anything changed.

sboesen commented 6 months ago

Ah, I see what you mean with creating multiple queues! Bah, in hindsight it's obvious - thank you for fixing it! Hope that fixes the final part of the "status bar jitter" we've been seeing. Really appreciate you deep diving and opening this PR! Merged.

kadisonm commented 6 months ago

No problem. Glad I'm able to help.

sboesen / remotely-sync

Status bar fixes + refactor #106