sboesen / remotely-sync

fork of remotely-save with security upgrades
Apache License 2.0
212 stars 8 forks source link

[Enhancement]: Display user friendly error for connection issues #59

Closed kadisonm closed 11 months ago

kadisonm commented 11 months ago

What happened?

I was syncing on mobile and it was taking a long time. It then showed this:

Screenshot_20231207_085550_md obsidian_edit_70290063915836

Not sure if this means anything.

What OS are you using?

Android

What remote cloud services are you using?

OneDrive for personal

Version of the plugin

0.4.25

Version of Obsidian

1.4.16

Using password or not

Ensure no sensitive information

sboesen commented 11 months ago

Hmm, I suspect this is either 1) a large file timing out or 2) poor network connection. The large file could be a metadata file if it has grown, remotely save had some reports about that. Does this keep happening?

kadisonm commented 11 months ago

Stopped right after but was just wondering if it should be something to concern about. Might help for the general user to just display a notice saying to check their internet connection or saying a file timed out. Since I think these are generally things the user can only really fix.

The large file could be a metadata file

Not sure.

sboesen commented 11 months ago

Can you share the error on the console (expanding the object)? Need to modify the exception handling code (main.ts:301 ish) to look for that error type in particular.

kadisonm commented 11 months ago

I'm not entirely sure I can reproduce because it stopped happening right after I refreshed the app.

sboesen commented 11 months ago

Sounds good, I'll close this one for now but if you can trigger it again and post the log (expanding the object logged) I can try to wrap it and provide a better error message. For now I think it's not a big deal

kadisonm commented 11 months ago

Hi is this related? I'm getting this after moving two files and renaming them.

image

Restarting seems to fix it.

I tried to recreate by moving a file to a new folder and renaming it. I couldn't get the error again on purpose but I did get it once for an unknown reason.

Here is what I found:

kadisonm commented 11 months ago

Please feel free to move this to a seperate issue if it is unrelated.

sboesen commented 11 months ago

Looks separate! Will move it