search

sbovo / ProjectBubbles

MIT License
2 stars 1 forks source link

Track events is a dependency #7

Open spontoreau opened 5 years ago

spontoreau commented 5 years ago

Please don't use a class with static a method to track event. This is clearly a dependency and it needs to be injected:

internal static void Log(string name, IDictionary<string, string> properties = null)
{
    Analytics.TrackEvent(name, properties);
}
sbovo commented 5 years ago

Correct.

spontoreau commented 5 years ago

We can first change that and resolve it with the DependencyResolver (we need some time to talk about that in the project: #8)