sbp / phenny

Python IRC bot
http://inamidst.com/phenny/
380 stars 233 forks source link

Added setup.py and used non-relative imports #8

Closed ipmb closed 13 years ago

ipmb commented 13 years ago

This change will let people install phenny with:

pip install -e git+https://github.com/sbp/phenny.git#egg=phenny

It also should be ready for uploading to PyPi.

sbp commented 13 years ago

Won't setuptools.find_packages() find ./__init__.py? Is there any way to make this work without creating a phenny/ subdirectory?

ipmb commented 13 years ago

I'm not sure off the top of my head. This is the common convention I've always seen used. It would probably pollute the global namespace web would be on your python path, instead of phenny.web. Maybe there's a way of hacking setup.py to make it work though.

sbp commented 13 years ago

One of the things that I've heard from users is that they love the fact you can just download the files and run it straight where it is, without having to use a package tool. Certainly it's inconvenient for people who prefer package handlers, but there is a debian package too. Since I use it locally myself, I can't change it and break that local functionality. Please do let me know if you manage to get that working though! I also appreciate the effort you made on this.