sbpp / sourcebans-pp

Admin, ban, and comms management system for the Source engine
https://sbpp.github.io/
Creative Commons Attribution Share Alike 4.0 International
336 stars 174 forks source link

[Feature Request] Suggestion for Updating Maps in the Server List #402

Open crashzk opened 6 years ago

crashzk commented 6 years ago

As you can see in the server list shows the servers online and when you click to check a server opens a box that shows the players and the image of the current map on the server.

Anyway, the list of maps is out of date for the CSGO maps.

Instead of replacing the images it would be better to separate them for each type of game, since maps change with each game, for example CSGO itself, Map Dust2 is not the same as CS: S and CS: GO and many others.

I would like to be able to launch in future updates so that each game looks for the image of the map in the folder of the game, it would be something like this:

/images/maps/csgo
/images/maps/cs
/images/maps/css
/images/maps/cscz

And so on in other games supported by SourceBans.

I hope you understand, and I apologize for my poor English.

rumblefrog commented 6 years ago

maps is out of date for the CSGO maps

We have yet to figure a programmatic way to generate map previews, the current method of importing previews is (a) google it and hope to find that someone took a screenshot (b) we manually go in game and load up the map and take screenshots

Neither method is that efficient, which is probably the reason why we haven't update the map previews in a long time

crashzk commented 6 years ago

I understand, it is that I am already updating myself manually, mine in the case.

Already in case if it had already this integrated update, it would update and if they allow later only annexed here the maps screens that had at the moment and you put them in the Git here.

Anyway, I'm waiting and thanks for now!

rumblefrog commented 6 years ago

I have found a way to generate map previews programmatically; I'll start working on it

rumblefrog commented 6 years ago

Another problem is that, for SourceBans++ to have a feasible coverage on maps, the map preview directory would be extremely large, so what I'm thinking is, instead of having people download map images as part of their installation, we can host a repo with Github pages, offering remote images

rumblefrog commented 6 years ago

@Groruk 1.6.3 milestone 🤔 If I can generate these previews in time

rumblefrog commented 6 years ago

Working preview: https://rumblefrog.keybase.pub/Source-Map-Thumbnails.mp4

crashzk commented 6 years ago

@RumbleFrog in case that same way that was done to capture the images could use in any other game?

rumblefrog commented 6 years ago

The code will need to be modified per game, as games work differently, but yes, it should work with most source games some minor edits

crashzk commented 4 years ago

I don't know if this implementation is going to be applied yet or not.

But recently I realized that GameTracker has options to send prints / photos of the maps to show when looking for a server.

I believe that it would be more interesting to make SourceBans search the image directly on GameTracker, if it has shows the image, if it doesn't have it leaves the default SourceBans image when there is no photo of the map.

I don't know if that would be possible, but recently I have been using a plugin on my server that takes the map photos directly on GameTracker.

https://forums.alliedmods.net/showthread.php?p=2629494

https://github.com/Bara/Discord-MapNotification/blob/master/scripting/discord_MapNotification.sp#L91