search

sbpp / sourcebans-pp

Admin, ban, and comms management system for the Source engine
https://sbpp.github.io/
Creative Commons Attribution Share Alike 4.0 International
333 stars 174 forks source link

Unmute/Ungag Options Not Available For Perm Punishments #844

Open fearts opened 1 year ago

fearts commented 1 year ago

What are the steps to reproduce this issue?

  1. Perm Mute/Gag someone
  2. Open website and go to that person's punishment
  3. There is no option to Unmute/Ungag them only "Add Comment" "Edit Details" "Delete Block"

If the punishment is not a Perm Mute/Gag then the Unmute/Ungag option does exist. Perm Bans have the Unban option so why do Perm Comms not have it? Without this option my head admins are unable to remove the punishment as I do not give them Delete/Edit permissions.

I'm using the php81 version of the webpanel.

Attached is a image demonstrating the issue. Thank you.

111112222

Rushaway commented 1 year ago

@rumblefrog Your commit https://github.com/sbpp/sourcebans-pp/commit/358d31e7345e700f1f5da0e55d9f5d889e2fe987 re-open this issue.

rumblefrog commented 1 year ago

@rumblefrog Your commit 358d31e re-open this issue.

Hm wasn't thinking with that one. But I'm not sure if removing the isset would be a good solution; it's creating an erroneous message every time the page is visited, so I added it back.

fearts commented 1 year ago

99c1de9d7e681078eb4b30b84eb73d53 ee5c10fefb5637cb9fcd10c6957e4bdf

Yea, with the newest release this is what it looks like with the fix Rush added.

rumblefrog commented 1 year ago

99c1de9d7e681078eb4b30b84eb73d53 ee5c10fefb5637cb9fcd10c6957e4bdf

Yea, with the newest release this is what it looks like with the fix Rush added.

That being said, warnings shouldn't be enabled in production environments. I'm not certain if that's configurable within NFO.