search

sbpp / sourcebans-pp

Admin, ban, and comms management system for the Source engine
https://sbpp.github.io/
Creative Commons Attribution Share Alike 4.0 International
333 stars 174 forks source link

Comms : You can Insert invalid STEAMID format in DB #850

Closed Rushaway closed 1 year ago

Rushaway commented 1 year ago

What are the steps to reproduce this issue?

  1. Requiere more than 1 target
  2. Perform a comms block on target with a multi target filter
  3. If one target has doesn't have a valid steam id, he wasn't checked.
  4. Inserting the bad steamid value in DB
  5. You just broke your comms website page display
  6. To fix it you have to delete the wrong line in DB manualy.

What happens?

Found a way to broke sourcebans website display

What were you expecting to happen?

Skip the invalid ID for don't insert it.

Any logs, error output, etc.?

N/A

Any other comments?

image

Check PR in comment for fix

What versions of software are you using?

Operating System: Ubuntu 20.04 SourceBans++ Version: Lastest (branch 8.1) SourceMod Version: 1.11.0.62 MetaMod Version: 1.11.0-dev+1148

Rushaway commented 1 year ago

@Hackmastr Can you re-open this issue ? Figured out sometime we can return a bad value from GetClientAuthId and break the code. Patch coming soon.