search

sbrandwoo / grunt-qunit-junit

JUnit compatible XML reporter for QUnit and grunt 0.4
MIT License
16 stars 5 forks source link

Merge with grunt-junit? #1

Closed jzaefferer closed 11 years ago

jzaefferer commented 11 years ago

It seems like this grunt plugin overlaps with https://github.com/johnbender/grunt-junit/ - can the two efforts be merged?

sbrandwoo commented 11 years ago

I used grunt-junit before grunt 0.4.0 came about, and it's very much designed around how the testing system worked in grunt 0.3.x. grunt-qunit-junit is designed to work with grunt 0.4's new event system, which makes it more robust and means I can improve the XML output (I have submitted a couple of PRs to grunt-contrib-qunit for this too).

So they have similar purpose, but due to the design of grunt a fairly different code structure to them.

jzaefferer commented 11 years ago

Alright, that makes sense. Let's see if John wants to continue maintaing his then.

Regarding the warning about grunt-contrib-junit - looks like you meant to warn about grunt-contrib-qunit. Any idea when that will get resolved? I'd like to avoid a github dependency when switching.

I'll close this anyway.

sbrandwoo commented 11 years ago

As soon as this pull request is accepted: https://github.com/gruntjs/grunt-contrib-qunit/pull/8

I'll also make a change or two to how classnames are generated, as the current implementation might be a bit specific to my use case.