search

sbraz / pymediainfo

A Python wrapper around the MediaInfo library
https://pymediainfo.readthedocs.org/
Other
314 stars 57 forks source link

Add a simpler example to the doc. #94

Closed JulienPalard closed 3 years ago

JulienPalard commented 4 years ago

I think that a first short example make a smoother introduction, at least I think that's what I searched while opening the doc, so I added it.

JulienPalard commented 4 years ago

Do you see anything else that would be worth adding?

I'll PR it if I see it. My idea was to add to the doc the specific topic I was searching for in the doc.

Maybe mentioning that objects can be dumped with to_data()?

Maybe. There's already an example of it, in the pprint, but that's ... short.

I've changed the PR title to fix a typo, can you do the same with the commit message?

Done, I bet it's not the first time I do this one.

Is it OK if I make a few changes to your commit while merging it? I might reword a thing or two.

Yes, totally OK.

sbraz commented 3 years ago

Hi @JulienPalard, What do you think of my expanded version of this PR?

JulienPalard commented 3 years ago

https://github.com/sbraz/pymediainfo/commit/d46d63d0e4a3194d3a3a6e635cd05a2199d2d4b1 Looks good to me :)

sbraz commented 3 years ago

Merci, merged :)