search

sbrl / Minetest-WorldEditAdditions

Extra tools and commands to extend WorldEdit for Minetest
https://worldeditadditions.mooncarrot.space/
Mozilla Public License 2.0
16 stars 3 forks source link

Probable moretrees planting solution #104

Open The4codeblocks opened 10 months ago

The4codeblocks commented 10 months ago

Use the "Fast Growth" variant of the saplings instead.

sbrl commented 8 months ago

Hello,

Thanks for suggesting, and sorry I didn't see this issue earlier! Do you have the node name for the fast growth variant? I'm pretty sure I've tested it, but just want to make sure.

I've tested both the normal and the _ongen ones..... and neither of them work due to the fact that moretrees saplings don't work in the same way to other types of saplings, e.g. in default, cooltrees, etc.

The4codeblocks commented 5 months ago

(sorry for being late) Is the problem that they're not being updated?

sbrl commented 5 months ago

The issue is that they are implemented differently and moretrees doesn't have an API that one can hook into to programmatically grow a tree IIRC @The4codeblocks.

We hook into TenPlus1's bonemeal mod to do the growificating of trees, and while there is scope for implementing support for multiple bonemeal mods (considered for a separate purpose in #106), it would be much easier if moretrees supported being grown by bonemeal the same as every other sapling.

IIRC moretrees is community maintained over in https://github.com/mt-mods/moretrees, so a PR over there is needed to add an API we can hook into here.

The4codeblocks commented 5 months ago

I think what I meant is using the built-in generation by using the saplings themselves.

sbrl commented 5 months ago

I'm not sure what you mean by "built-in generation", @The4codeblocks?

The4codeblocks commented 5 months ago

I'm not sure what you mean by "built-in generation", @The4codeblocks?

The moretrees generation used in saplings.

sbrl commented 4 months ago

Yeah, unfortunately the built-in generation function you mention is accessible to moretrees and not to other mods if I recall correctly.

The4codeblocks commented 4 months ago

Yeah, unfortunately the built-in generation function you mention is accessible to moretrees and not to other mods if I recall correctly.

I'm trying to say that you can call it, by placing a sapling.

sbrl commented 3 months ago

I'm trying to say that you can call it, by placing a sapling.

Right. Does that require a player to place the sapling, or can it be done by calling a function?

Currently WorldEditAdditions places saplings using VoxelManipulators, so it doesn't trigger any functions associated with nodes when they are placed.

I know there's also minetest.set_node(), but I haven't tried using this. It's also supposed to be quite inefficient if called a large number of times AFAIK.