search

sbrl / Minetest-WorldEditAdditions

Extra tools and commands to extend WorldEdit for Minetest
https://worldeditadditions.mooncarrot.space/
Mozilla Public License 2.0
16 stars 3 forks source link

//move+ param2 overwrite fault #78

Open VorTechnix opened 2 years ago

VorTechnix commented 2 years ago

When moving nodes there is a fault that sets the param2 values of all moved nodes to the param2 values of the nodes at the positions they are moved to.

Before move: image

After move: image

Note: nodes take the param2 value of the node that was in their positions previously.

When moved back to original position the param2 values restore.

This bug happens regardless of move direction or distance.

After big move into air where no nodes have been all param2s become 0: image

After moving the nodes back to original positions the param2s restored so my guess is that the param2 values were retained by the air nodes in the moved nodes' original locations.

sbrl commented 2 years ago

Yeah, this is a bug..

You've got the right idea here - when we use a Voxel Manipulator to move nodes, we only move the node ids here and not the param1 / param2 values. We need to also copy param1/param2 explicitly.