search

sbrl / Pepperminty-Wiki

A wiki in a box
https://peppermint.mooncarrot.space/
Mozilla Public License 2.0
180 stars 22 forks source link

Fix repeated page names on sidebar #135

Closed ikisler closed 7 years ago

ikisler commented 7 years ago

For cases like this, pages appear twice on the sidebar: image

Added code to check if page already appears in sidebar. If so, continue the loop, keeping the page from appearing twice.

sbrl commented 7 years ago

Heya! Thanks for the PR! As yo can probably see, these are my first ever pair of PRs on my own code. I didn't know that anyone else was using it! Glad to know that someone is finding it useful, and I hope that the recent updates haven't been too bothersome - my upgrade instructions have left much to be desired.... :P

Anyway, would it be possible to remove index.php from this PR? If not it's not an issue :-) Other than that it's fine, and ready to be merged! :smiley_cat:

ikisler commented 7 years ago

Hi!

Yeah, I just started using it in the last two weeks or so to document an automated test suite that I'm developing. I think the concept of the wiki in a box is very cool.

I wasn't sure what files I needed to change when doing a pull request, which is why I included both index.php and the module file. Let me remove that file and update the PR

ikisler commented 7 years ago

Okay, I think we're good.

Let me know if anything else needs to be done. :3

Thank you!

sbrl commented 7 years ago

Thanks for updating that. Pepperminty Wiki has a custom build system that I made that automatically packs everything into index.php you see. I could tell you hadn't run that, as you hadn't included an update to the module index.

You can run it yourself if you like life on the bleeding edge by running make peppermint or php build.php.

That's a cool use! I hadn't thought of using it for documentation purposes. I'm glad you're finding it useful!

And yeah, I thought it was too! I've had quite the headache in the past installing and configuring MediaWiki, so I thought that it was time for something a bit lighter. My goal is to eventually implement all the useful features that you'd expect to find in a more mainstream wiki, while adding my own personal touch by refreshing some of the ideas, and listening to feedback.

sbrl commented 7 years ago

Merge complete! 😸